Re: lilypond ./ChangeLog lily/dynamic-engraver.cc l...

[Erlend Aasland]

Hi Han-Wen

On 5/16/06, Han-Wen Nienhuys <address@hidden> wrote:

diff -u lilypond/lily/hairpin.cc:1.65 lilypond/lily/hairpin.cc:1.66
--- lilypond/lily/hairpin.cc:1.65       Tue Apr 11 12:36:44 2006
+++ lilypond/lily/hairpin.cc    Tue May 16 19:00:39 2006
@@ -162,7 +162,7 @@
                    x_points[d] = e.center () - d * padding / 3;
                }
              else
-               x_points[d] = e[d];
+               x_points[d] = e[d] - d * padding;
            }
        }
     }

This change looks a bit weird to me. Should not this padding only be applied if the right part of the hairpin is attached to a barline (and not a note)? That is, something like this:

--- lily/hairpin.cc     16 May 2006 19:00:39 -0000      1.66
+++ lily/hairpin.cc     18 May 2006 06:56:39 -0000
@@ -162,7 +162,11 @@ Hairpin::print (SCM smob)
                    x_points[d] = e.center
 () - d * padding / 3;
                }
              else
-               x_points[d] = e[d] - d * padding;
+               if (d == RIGHT &&
+                   !me->get_bound (RIGHT)->get_column ()->is_musical (me->get_bound (RIGHT)->get_column ()))
+                 x_points[d] = e[d] - d * padding;
+               else
+                 x_points[d] = e[d];
            }
        }
     }


Regards,
  Erlend Aasland