[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "A
From: |
Reinhold Kainhofer |
Subject: |
Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120) |
Date: |
Thu, 12 Jun 2008 23:09:28 +0200 |
User-agent: |
KMail/1.9.9 |
Am Mittwoch, 11. Juni 2008 schrieb Neil Puttock:
> 2008/6/6 Reinhold Kainhofer <address@hidden>:
> > Attached is a patch (for current master), which is my first attempt to
> > implent this. The patch is not perfect yet, but works really well. What
> > it does: - Extend the parser to allow the above forms for \tempo
> > - Add a tempoText property, similar to tempoUnitCount
> > - Metronome_mark_engraver uses this property and checks whether it has
> > changed
> > - Extend the metronomeMarkFormatter to take four arguments (text,
> > duration, count, context) and print either the text, the note=count or
> > text (note=count), depending on whether the properties are set to
> > sensible values.
Here is an updated patch with all the issues resolved. I've also added a
regression test, the corresponding PDF file is uploaded at:
http://www.fam.tuwien.ac.at/~reinhold/temp/metronome-text.pdf
I also added a convert-ly rule to warn the user if he uses a custom function
for metronomeMarkFormatter.
> That's really good.
>
> If I might make a suggestion, it would be nice to have an additional
> feature whereby the tempo can be set silently (perhaps controlled by a
> boolean context property), which would allow the text to be displayed
> while preserving the default behaviour of \tempo.
Implemented. Use \set Score.tempoHideNote = ##t to hide the note.
> Do you need to have two extra functions in ly-syntax-constructors.scm?
> They seem a bit out of place there, since they're too specific (being
> a subset of tempo).
Right, I now implemented both in the tempo function (for \tempo 4=120, the
text argument is #f, which is then checked in the tempo function). For
\tempo "Text" I have left the tempoText function, because in that case I
shouldn't touch the duration and count values.
> Could the tempo function be rewritten to incorporate the other
> options, with default values being passed by the parser for the
> properties not set?
Which other options are you talking about?
Okay to apply?
Cheers,
Reinhold
--
------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
* Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
* K Desktop Environment, http://www.kde.org, KOrganizer maintainer
* Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
0001-Feature-Include-text-in-tempo-indications.patch
Description: Text Data
metronome-text.ly
Description: Text Data
- [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120), Reinhold Kainhofer, 2008/06/06
- Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120), Neil Puttock, 2008/06/10
- Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120), Reinhold Kainhofer, 2008/06/10
- Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120),
Reinhold Kainhofer <=
- Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120), Neil Puttock, 2008/06/12
- Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120), Reinhold Kainhofer, 2008/06/13
- Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120), Reinhold Kainhofer, 2008/06/19
- Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120), Han-Wen Nienhuys, 2008/06/21
- Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120), Reinhold Kainhofer, 2008/06/23
- Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120), Neil Puttock, 2008/06/24
- Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120), Reinhold Kainhofer, 2008/06/24