Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120)

[Reinhold Kainhofer]

Am Freitag, 13. Juni 2008 schrieb Neil Puttock:
> 2008/6/12 Reinhold Kainhofer <address@hidden>:
> > Am Mittwoch, 11. Juni 2008 schrieb Neil Puttock:
> >
> > Here is an updated patch with all the issues resolved. I've also added a
> > regression test, the corresponding PDF file is uploaded at:
> > http://www.fam.tuwien.ac.at/~reinhold/temp/metronome-text.pdf
-...]
> - since format-metronome-markup determines whether to create the text
> markup by checking for an empty list, you probably want the parser to
> send SCM_EOL for \tempo dur = count; otherwise you'll get the
> unfortunate result shown below. :)

Oops, you really got me there. If there is a text, I set the tempoText 
property, but I forgot that if that property is already set, I need to unset 
it there... Fixed with the attached patch.

> - ideally, you need two concat operations to prevent the spaces around
> the equals sign being lost.

Right. However, using two concats would make things much more complicated. I 
simply inserted an explicit space before and after the =...

Cheers,
Reinhold


-- 
------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/

0001-New-Feature-Include-text-in-tempo-indications.patch
Description: Text Data