Re: Code review tool? (and [PATCH] fix for stencil rotating)

[Reinhold Kainhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Mittwoch, 10. September 2008 schrieb Carl D. Sorensen:
> I've been using a bunch of local commits to track my changes, then using
> git-rebase to squash them into a single change before I push.  If you do
> this, then the rebase commit will fly through, won't it?
>
> Is this a wrong thing to do?  I've thought it worked well for me.

It's fine, that's also how I do it. However, git-rebase does not squash them 
into a single commit, but tries to preserve all commits as you committed 
them. So your branch will still have multiple commits...

Cheers,
Reinhold


- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIyXJJTqjEwhXvPN0RAh1NAKCz6Zh3LP9/TMz8FJt12PgtWfectACgxtCl
PnBIde9Pa98yhgQLxQTb+Ws=
=LT0g
-----END PGP SIGNATURE-----