Re: Code review tool? (and [PATCH] fix for stencil rotating)

[Reinhold Kainhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Mittwoch, 10. September 2008 schrieb Evan Martin:
> On Wed, Sep 10, 2008 at 8:34 AM, Reinhold Kainhofer
> > It would also be very useful if git-cl let you select one patch (not
> > necessarily the latest, so no diff of current head to some other point)
> > to upload. In this case, the description / summary can be taken from the
> > commit message.
>
> The last argument to "git cl upload" is passed along to "git diff", so
> something like
>   git cl upload HEAD^^ HEAD^
> would upload just the patch one version back.

Okay, that works, but (1) is awkward if you want to upload a patch a few 
versions back (you basically have to lookup the hashes of both the commit you 
want to upload and the one before) and (2) completely ignores the commit 
message for that commit. After all, I already described my commit in the 
commit message, so git-cl could/should reuse that.

How about extending git-cl to allow uploading a single commit (not even 
necessarily in the same branch as you are currently on)? Something like
      git-cl upload-commit HERECOMETHEHASHES
git-cl would then use the first line of the commit message as summary and the 
rest as the long description... if multiple commits are given, they are 
uploaded as separate patch sets to the same issue (or maybe as separate 
issues?).
Of course, this could even be extended to automatically upload all commits in 
the current branch (starting at some commit that needs to be further 
defined...)
That would feel much more git-like than the current "git-cl upload".

Cheers,
Reinhold

- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIyXzYTqjEwhXvPN0RAmoWAJ4x/keW8vKOVQdPXAPKr5dsQb/iXwCfY3WE
Vd1LaDO63dWO7k2n36OF+pA=
=Al9V
-----END PGP SIGNATURE-----