|
From: | hanwenn |
Subject: | Re: * Fix arpeggio overshoot for chords which reach centre line. |
Date: | Fri, 03 Oct 2008 14:52:28 -0700 |
lgtm http://codereview.appspot.com/6453/diff/205/6 File lily/arpeggio.cc (right): http://codereview.appspot.com/6453/diff/205/6#newcode22 Line 22: #define EPS 1e-3 use const http://codereview.appspot.com/6453/diff/205/6#newcode109 Line 109: while (mol.extent (Y_AXIS).length () + EPS < heads.length ()) why should this be 1e-3? Can you look at some real scans do determine what a reasonable number? Also, I'd probably write while (mol.extent + squiggle_length < heads.length() + overshoot) http://codereview.appspot.com/6453
[Prev in Thread] | Current Thread | [Next in Thread] |