|
From: | joeneeman |
Subject: | Re: Fix key signatures with accidentals in specific octave. |
Date: | Fri, 17 Apr 2009 19:25:32 +0000 |
http://codereview.appspot.com/11052/diff/3409/2410 File scm/music-functions.scm (right): http://codereview.appspot.com/11052/diff/3409/2410#newcode1047 Line 1047: ((and (equal? ignore-octave #f) I think eq? is more appropriate here http://codereview.appspot.com/11052/diff/3409/2410#newcode1048 Line 1048: (and use (and a b c) instead of (and a (and b c)) http://codereview.appspot.com/11052/diff/3409/2410#newcode1073 Line 1073: (if (and (not (= (sign this-alt) 0)) Surely (= (sign x) 0) is the same as (= x 0) http://codereview.appspot.com/11052/diff/3409/2410#newcode1075 Line 1075: (< (sign (* prev-alt this-alt)) 0))) Surely (< (sign x) 0) is the same as (< x 0) http://codereview.appspot.com/11052
[Prev in Thread] | Current Thread | [Next in Thread] |