Improve implementation of dashed slurs

[n . puttock]

http://codereview.appspot.com/41099/diff/1021/52
File Documentation/user/expressive.itely (right):

http://codereview.appspot.com/41099/diff/1021/52#newcode634
Line 634: @lilypondfile[verbatim,lilyquote,texidoc,doctitle]
@ignore this unless you're going to run makelsr.py (or create input/lsr
file by hand)

http://codereview.appspot.com/41099/diff/1021/54
File input/new/making-slurs-with-complex-dash-structure.ly (right):

http://codereview.appspot.com/41099/diff/1021/54#newcode3
Line 3: \header{
space

http://codereview.appspot.com/41099/diff/1021/54#newcode4
Line 4: texidoc = "
needs snippet directory tag otherwise makelsr.py will fail

lsrtags = "rhythms, expressive"

http://codereview.appspot.com/41099/diff/1021/58
File lily/arpeggio.cc (right):

http://codereview.appspot.com/41099/diff/1021/58#newcode168
Line 168: Stencil mol (Lookup::slur (curve, lt, lt, SCM_UNDEFINED));
add dash ability too?

http://codereview.appspot.com/41099/diff/1021/59
File lily/bezier.cc (right):

http://codereview.appspot.com/41099/diff/1021/59#newcode277
Line 277: Offset p[CONTROL_COUNT][CONTROL_COUNT];
Offset is described in offset.hh as 2d vector, so should use a vector of
Offsets

http://codereview.appspot.com/41099/diff/1021/59#newcode296
Line 296: Bezier::extract (Real t_min, Real t_max)
ensure t_min and t_max stay within bounds?

negative values and >1 produce outlandish curves

http://codereview.appspot.com/41099/diff/1021/59#newcode305
Line 305: {
no {}

http://codereview.appspot.com/41099/diff/1021/59#newcode309
Line 309: {
no {}

http://codereview.appspot.com/41099/diff/1021/62
File lily/lookup.cc (right):

http://codereview.appspot.com/41099/diff/1021/62#newcode346
Line 346: Lookup::slur (Bezier curve, Real curvethick, Real linethick,
is passing SCM allowed in lookup.cc?

http://codereview.appspot.com/41099/diff/1021/62#newcode351
Line 351: /* calculate the offset for the two beziers that make the
sandwich
tidy comments

http://codereview.appspot.com/41099/diff/1021/62#newcode363
Line 363: if ((dash_details == SCM_UNDEFINED) || (dash_details ==
SCM_EOL))
!scm_is_pair ()

http://codereview.appspot.com/41099/diff/1021/62#newcode364
Line 364: { /* solid slur  */
new line

http://codereview.appspot.com/41099/diff/1021/62#newcode368
Line 368: { /* dashed or combination slur */
new line

http://codereview.appspot.com/41099/diff/1021/62#newcode370
Line 370: for (int i=0; i<num_segments; i++)
i < num_segments

should print warning if segments overlap, or just silently ignore?

http://codereview.appspot.com/41099/diff/1021/62#newcode382
Line 382: {
no {}

http://codereview.appspot.com/41099/diff/1021/62#newcode408
Line 408: }/* end for num_segments */
don't need these comments

http://codereview.appspot.com/41099/diff/1021/66
File ly/property-init.ly (right):

http://codereview.appspot.com/41099/diff/1021/66#newcode13
Line 13: #(define (make-simple-dash-definition dash-fraction
dash-period)
this doesn't belong here

http://codereview.appspot.com/41099/diff/1021/66#newcode19
Line 19: slurDashPattern =
these should go in music-functions-init.ly

http://codereview.appspot.com/41099/diff/1021/67
File python/convertrules.py (right):

http://codereview.appspot.com/41099/diff/1021/67#newcode2903
Line 2903: if (re.search(r'\'dash-fraction', str) or
re.search(r'\'dash-period', str):
limit search to Slur/Tie/PhrasingSlur otherwise users will get this
message for other grobs

http://codereview.appspot.com/41099/diff/1021/68
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/41099/diff/1021/68#newcode174
Line 174: (dash-definition ,pair? "List of @code{dash-elements} defining
the
list?

http://codereview.appspot.com/41099