Re: New markup commands: \left-brace & \right-brace.

[Carl . D . Sorensen]

Code looks good to me.

I have a couple of optional minor nitpicks.

Thanks,

Carl



http://codereview.appspot.com/8874/diff/5202/4204
File scm/define-markup-commands.scm (right):

http://codereview.appspot.com/8874/diff/5202/4204#newcode2623
Line 2623: (ly:font-get-glyph font (string-append "brace"
(number->string n)))))
Do we want to keep line length to <80 chars?

http://codereview.appspot.com/8874/diff/5202/4205
File scm/lily-library.scm (right):

http://codereview.appspot.com/8874/diff/5202/4205#newcode555
Line 555: "Find the index between START and END (an integer) which
Use @var{start} instead of START ?
Use (_i "docstring") to allow internationalization?

http://codereview.appspot.com/8874