Re: Rewriting x11-color.scm

[Han-Wen Nienhuys]

On Thu, Jul 23, 2009 at 12:15 AM, Neil Puttock<address@hidden> wrote:
> 2009/7/21 Mark Polesky <address@hidden>:
>> I rewrote x11-color.scm so that now the color-list is generated
>> semi-automatically. It's more organized, easier to read, and less
>> than a quarter of its original size. But does my approach slow
>> things down at all? Measurably? I figure the current version is
>> probably faster because no calculations need to be made during the
>> definition of the color-list. But I don't have a good sense of the
>> impact of this. I'm not posting a patch here because I'm pretty
>> sure it would be way too big for the list-server.
>>
>> Anyway, please comment if you can.
>
> Very nice. :)
>
> A good (but tedious) test of whether it's impacting on compile times
> would be to compare doc builds with and without the changes, since
> there are so many LilyPond invocations for the snippets.
>

It sure looks nice, but since x11-color.scm is basically dumb data,
this change introduces more places where bugs could hide.


-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen