[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tracker 836: Add facility to change output file-name for a \book blo
From: |
Carl . D . Sorensen |
Subject: |
Re: Tracker 836: Add facility to change output file-name for a \book block |
Date: |
Thu, 12 Nov 2009 01:12:36 +0000 |
A few whitespace errors (tab following spaces) and one indenting
mistake. Then I think it's good to go.
http://codereview.appspot.com/150044/diff/11/1015
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/150044/diff/11/1015#newcode611
ly/music-functions-init.ly:611: (filter
Tab following space -- we never want to have that. Start the line with
as many tabs as desired, followed by spaces if necessary to create the
proper indentation. Or use all spaces -- that's fine too. But not
space tab space.
http://codereview.appspot.com/150044/diff/11/1015#newcode612
ly/music-functions-init.ly:612: (lambda (m) (eq? 'NoteEvent
(ly:music-property m 'name)))
Tab following space
http://codereview.appspot.com/150044/diff/11/1015#newcode613
ly/music-functions-init.ly:613: (ly:music-property ev-chord
'elements))))
Tab following space
http://codereview.appspot.com/150044/diff/11/1015#newcode624
ly/music-functions-init.ly:624: (for-each (lambda (m)
(for-each should align with (ly:pitch?.
(if (test-expression)
(true-expression)
(false-expression))
http://codereview.appspot.com/150044/diff/11/1015#newcode626
ly/music-functions-init.ly:626: (begin
After changing for-each, you'll need to change (begin to match.
http://codereview.appspot.com/150044/diff/11/1015#newcode633
ly/music-functions-init.ly:633: trill-events)))))
Tab following spaces
http://codereview.appspot.com/150044
- Re: Tracker 836: Add facility to change output file-name for a \book block, (continued)
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/04
- Re: Tracker 836: Add facility to change output file-name for a \book block, ian, 2009/11/04
- Re: Tracker 836: Add facility to change output file-name for a \book block, ian, 2009/11/04
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/04
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/04
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/08
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/08
- Re: Tracker 836: Add facility to change output file-name for a \book block, ian, 2009/11/09
- Re: Tracker 836: Add facility to change output file-name for a \book block, ian, 2009/11/11
- Re: Tracker 836: Add facility to change output file-name for a \book block,
Carl . D . Sorensen <=
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/12
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/12
- Re: Tracker 836: Add facility to change output file-name for a \book block, n . puttock, 2009/11/12
- Re: Tracker 836: Add facility to change output file-name for a \book block, ian, 2009/11/12