[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] scm/define-markup-commands.scm: remove some unnecessary
From: |
Han-Wen Nienhuys |
Subject: |
Re: [PATCH 1/4] scm/define-markup-commands.scm: remove some unnecessary lookups |
Date: |
Mon, 23 Nov 2009 00:10:52 -0200 |
LGTM
On Sun, Nov 22, 2009 at 10:03 PM, David Kastrup <address@hidden> wrote:
> ---
> scm/define-markup-commands.scm | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> This patch series makes the syntax of builtin markup
> commands upwards compatible with the user level ones.
>
> diff --git a/scm/define-markup-commands.scm b/scm/define-markup-commands.scm
> index 449f3c7..0910f81 100644
> --- a/scm/define-markup-commands.scm
> +++ b/scm/define-markup-commands.scm
> @@ -824,7 +824,6 @@ If there are no arguments, return an empty stencil.
> stencils))
> (text-width (apply + text-widths))
> (word-count (length stencils))
> - (prop-line-width (chain-assoc-get 'line-width props #f))
> (line-width (or line-width (ly:output-def-lookup layout 'line-width)))
> (fill-space
> (cond
> @@ -3290,7 +3289,7 @@ where @var{X} is the number of staff spaces."
> ((baseline-skip))
> "Like @code{\\column}, but return a list of lines instead of a single
> markup.
> address@hidden determines the space between each markup in @var{args}."
> - (space-lines (chain-assoc-get 'baseline-skip props)
> + (space-lines baseline-skip
> (interpret-markup-list layout props args)))
>
> (define-builtin-markup-list-command (override-lines layout props new-prop
> args)
> --
> 1.6.5.3.153.g0670
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/lilypond-devel
>
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, (continued)
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Han-Wen Nienhuys, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Carl Sorensen, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Joe Neeman, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/24
Re: [PATCH 2/4] scm/harp-pedals.scm: Fold make-harp-pedal into \harp-pedal markup., Reinhold Kainhofer, 2009/11/23
Re: [PATCH 1/4] scm/define-markup-commands.scm: remove some unnecessary lookups,
Han-Wen Nienhuys <=
Re: [PATCH 1/4] scm/define-markup-commands.scm: remove some unnecessary lookups, Reinhold Kainhofer, 2009/11/23