[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] scm/harp-pedals.scm: Fold make-harp-pedal into \harp-ped
|
From: |
Reinhold Kainhofer |
|
Subject: |
Re: [PATCH 2/4] scm/harp-pedals.scm: Fold make-harp-pedal into \harp-pedal markup. |
|
Date: |
Mon, 23 Nov 2009 11:21:42 +0100 |
|
User-agent: |
KMail/1.12.3 (Linux/2.6.31-14-generic; KDE/4.3.3; i686; ; ) |
Am Montag, 23. November 2009 01:03:11 schrieb David Kastrup:
> The already outcommented problematic \harp-pedal-verbose markup is
> removed completely. Inlining make-harp-pedal makes it possible to use
> the property binding mechanism of define-builtin-markup-command in
> order to minimize inconsistencies between documentation and behavior.
As the author of the harp pedals code, I'm fine with that change (provided the
regtest still works, which I haven't checked).
Cheers,
Reinhold
--
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
* Financial & Actuarial Math., Vienna Univ. of Technology, Austria
* http://www.fam.tuwien.ac.at/, DVR: 0005886
* LilyPond, Music typesetting, http://www.lilypond.org
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, (continued)
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Kieren MacMillan, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Werner LEMBERG, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Han-Wen Nienhuys, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Carl Sorensen, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, Joe Neeman, 2009/11/23
- Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords, David Kastrup, 2009/11/24
Re: [PATCH 2/4] scm/harp-pedals.scm: Fold make-harp-pedal into \harp-pedal markup.,
Reinhold Kainhofer <=
Re: [PATCH 1/4] scm/define-markup-commands.scm: remove some unnecessary lookups, Han-Wen Nienhuys, 2009/11/22
Re: [PATCH 1/4] scm/define-markup-commands.scm: remove some unnecessary lookups, Reinhold Kainhofer, 2009/11/23