Re: Add option to indicate frets by letters in tablature (issue164063)

[Carl . D . Sorensen]

Looks great to me.

I have a couple of comments.

Thanks for doing this!

Carl


http://codereview.appspot.com/164063/diff/2001/3008
File scm/translation-functions.scm (right):

http://codereview.appspot.com/164063/diff/2001/3008#newcode393
scm/translation-functions.scm:393: (define-public
(fret-letter-tablature-format str context event)
The change from string to str is contrary to the desired goal in
LilyPond programming.

The goal is to have all variable names be english words, rather than
abbreviations of english words.

There is lots of legacy code where that is not true, but we should not
be writing new code like this.

http://codereview.appspot.com/164063/diff/2001/3008#newcode399
scm/translation-functions.scm:399: (make-vcenter-markup
If length of 'fretLetterExceptions is greater than zero, I think we
ought to throw a warning if fret is higher than the length of
'fretLetterExceptions so that the user will have an idea of why things
didn't work the way they wanted it to.

http://codereview.appspot.com/164063