Re: Issue 659: alternate segno symbol (issue181144)

[Carl . D . Sorensen]

Looks good to me, with the exception of the hardcoded value stuff.

Thanks,

Carl



http://codereview.appspot.com/181144/diff/4008/5018
File lily/bar-line.cc (right):

http://codereview.appspot.com/181144/diff/4008/5018#newcode242
lily/bar-line.cc:242: m.add_at_edge (X_AXIS, RIGHT, thick, 2.5 *
staff_space + 2 * thinkern); // Urg, hardcoded value
If you are going to use the hardcoded value (which I think is not a good
idea;  you can call ly_stencil_extent to get the width of the segno
stencil), then I think it would be better to define a local variable for
your hardcoded value, i.e.
float segno_width = 2.5 * staff_space // Urg, hardcoded value

so that it's clear what the 2.5 is for.

http://codereview.appspot.com/181144/show