Re: Issue 659: alternate segno symbol (issue181144)

[Marc Hohl]

address@hidden schrieb:
> Hi Marc,
>
> LGTM, though I still think this is a lot of effort for a very obscure
> and little-used symbol.
Perhaps it is little-used because it was missing in lilypond? ;-)

Or do you think this is just too much and we should forget about it all?
(I don't hope so, because I spent hours on it, but anyway ...)
> Cheers,
> Neil
>
>
> http://codereview.appspot.com/181144/diff/5028/4010
> File input/regression/bar-line-segno.ly (right):
>
> http://codereview.appspot.com/181144/diff/5028/4010#newcode2
> input/regression/bar-line-segno.ly:2: \header { texidoc = "Segno bar
> lines can be used to mark
> newline for texidoc
Done.
> http://codereview.appspot.com/181144/diff/5028/4010#newcode7
> input/regression/bar-line-segno.ly:7: \paper {  ragged-right = ##t }
> { ragged-right
Done.
> http://codereview.appspot.com/181144/diff/5028/4011
> File lily/bar-line.cc (right):
>
> http://codereview.appspot.com/181144/diff/5028/4011#newcode97
> lily/bar-line.cc:97: Stencil segno;
> I'd move this back to a separate if { } block (like Reinhold suggested
> for your original patch)
>
> (see below)
Done.
> http://codereview.appspot.com/181144/diff/5028/4011#newcode210
> lily/bar-line.cc:210: else if (str == "S")
> (as mentioned above)
>
> else if (str.find ("S") != NPOS || str = "|._.|")
>   {
>     Stencil segno
>     ...
>
>     if (str == "S")
>       {
>         ...
Thanks for your comments!

Marc

http://codereview.appspot.com/181144/show