Re: Enhancements on Issue 659: alternate segno symbol (issue181144)

[Marc Hohl]

Carl Sorensen schrieb:
> On 2/15/10 12:33 PM, "Marc Hohl" <address@hidden> wrote:
>
>   
> > Hello all,
> >
> > I have uploaded some enhancements due to Alexander Kobel's proposals.
> > The first attempt to upload broke on my console with some error messages,
> > so I did it again - now I see that I uploaded two identical versions.
> > And furthermore, the changes to scm/tablature.scm which Carl had pushed
> > already are in this patch set, too, due to a missing "git pull" just before
> > rebasing, so I uploaded another version.
> >     
>
> When you upload a patch set that has errors in it, you can delete the patch
> set using the Delete patch set  link on the issues home page.
>   
Didn't know that option - thanks for the hint!
> I used to just be embarrassed when I posted bad patch sets; now I just
> delete them and post a new one right away.
>
> The other thing I discovered that helped with my "oops" patches on Rietveld
> is that I can do "git diff" before I do "git-cl upload" and that gives me a
> chance to review things locally.
>   
Actually, I did a "git diff" but somehow overlooked the spurious tablature
entry (WYSIWYWTS: what you see is what you want to see :-)
>   
> > It would be fine to calculate the width of the segno stencil automatically,
> > but I hardcoded the value, so it seems to work fine.
> >     
>
> Have you checked it with various staff sizes?
>   
Yes. The width of the segno sign is 2.5 staff_spacing units, so the
hardcoded value is clumsy, but correct.

Marc