Re: [PATCH]: Allow context modifications to be stored in a variable and inserted into \context or \with

[Reinhold Kainhofer]

Am Freitag, 12. März 2010 14:41:20 schrieb Reinhold Kainhofer:
> Our problems with \RemoveEmptyStaffContext resetting previous context
> modifications highlights one problem we have: So far, it was not possible
> to store a bunch of context modifications into a variable and apply them
> later on.

An updated patch is now available at 
    http://codereview.appspot.com/475041

I have included Neil's suggestions, as well as some of my own observations. I 
also added convert-ly rules (although \RemoveEmptyStaffContext still works, 
it's better to use \Staff\RemoveEmptyStaves instead). 
The patch also passes "make check" with no changes (except the test-output-
distance.ly, of course!)

The only thing I'm not happy about is that parser keywords are all-lowercase, 
so we now have the ugly-looking command \contextmodifications...


What is not included:
-) Documentation: Don't tell the user about \RemoveEmptyStaffContext any more, 
but rather use \Staff \RemoveEmptyStaves; document \contextmodifications; 
document the fact that \with blocks can be stored in variables.
-) Scheme interface to Context_mod and Context_def (I'll need these for my 
OrchestralLily package anyway, so sooner or later I'll have to write them)


Okay to apply?
Cheers,
Reinhold

-- 
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org