lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Cleanup: sort header order, use explicit std:: prefix rather than using


From: hanwenn
Subject: Cleanup: sort header order, use explicit std:: prefix rather than using std; (issue681041)
Date: Sun, 21 Mar 2010 18:23:16 +0000

Reviewers: ,

Message:
Hi guys,

this is a general cleanup of Font_metric related code.

there are some backward incompatible changes (removal of SCM functions),
but I believe it should be safe, because the functions were not useful,
little used anyway.

Description:
Cleanup: sort header order, use explicit std:: prefix rather than using
std;


Remove from header too.


Remove Font_metric::index_to_ascii.


Remove Font_metric::get_indexed_char_stencil()


Rename Font_metric::get_indexed_char() to
Font_metric::get_indexed_char_dimensions().


Remove Font_metric::get_ascii_char() and descendents.


Be const correct in Open_type_font::index_to_charcode()


Remove ly:get-glyph and supporting infrastructure.


Cleanup: remove Simple_font_metric, Font_metric::text_dimension


Add Output_def argument to Font_metric::text_stencil().

Side effects:

- remove fontify-text, fontify-white-text

- remove ly:text-dimension

- remove output-ps.scm (text ) output expression.

Cleanup and document scale-layout; mark cloned layout by setting 'clone
= #t.


Remove unused indirection function Font_metric::text_stencil and derived
versions.


indent fix.

Please review this at http://codereview.appspot.com/681041/show

Affected files:
  M lily/book.cc
  M lily/font-metric-scheme.cc
  M lily/font-metric.cc
  M lily/include/font-metric.hh
  M lily/include/modified-font-metric.hh
  M lily/include/open-type-font.hh
  M lily/include/pango-font.hh
  M lily/modified-font-metric.cc
  M lily/note-head.cc
  M lily/open-type-font.cc
  M lily/pango-font.cc
  M lily/system-start-delimiter.cc
  M lily/text-interface.cc
  scm/output-ps.scm
  scm/paper.scm
  scm/safe-lily.scm
  scm/stencil.scm






reply via email to

[Prev in Thread] Current Thread [Next in Thread]