[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Lilypond-book: Factor out the formatting from lilypond-book into sep
|
From: |
Graham Percival |
|
Subject: |
Re: Lilypond-book: Factor out the formatting from lilypond-book into separate classes (issue1543042) |
|
Date: |
Fri, 11 Jun 2010 14:27:43 +0100 |
On Fri, Jun 11, 2010 at 2:21 PM, Reinhold Kainhofer
<address@hidden> wrote:
> Am Freitag, 11. Juni 2010, 14:59:23 schrieb Graham Percival:
>> On Fri, Jun 11, 2010 at 12:59 PM, <address@hidden> wrote:
>> > Please review this at http://codereview.appspot.com/1543042/show
>>
>> I think you pushed it to master accidentally.
>
> No, not accidentally. You said "LGTM" and Neil confirmed this and asserted
> that info images also looked fine, so I commited it.
> I pushed it after fixing the only complaint about option display with --help.
err... ok. Google mail received an email from you at 12:59 (it's now
14:26) saying "please review this at..." oh, wait! Does the
codereview website automatically append that to emails? That would
make sense, and would explain everything!
Cheers,
- Graham