Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041)

[n . puttock]

Hi Jan,

Here are some more comments for you.

Cheers,
Neil


http://codereview.appspot.com/1579041/diff/19001/20003
File lily/metronome-engraver.cc (right):

http://codereview.appspot.com/1579041/diff/19001/20003#newcode81
lily/metronome-engraver.cc:81: && g->get_property_data
("break-align-symbol")
get_property ()

http://codereview.appspot.com/1579041/diff/19001/20003#newcode82
lily/metronome-engraver.cc:82: == ly_symbol2scm ("staff-bar"))
can't this be incorporated into 'break-align-symbols for MetronomeMark?

http://codereview.appspot.com/1579041/diff/19001/20003#newcode86
lily/metronome-engraver.cc:86: && scm_member (g->get_property_data
("break-align-symbol"),
get_property ()

http://codereview.appspot.com/1579041/diff/19001/20003#newcode87
lily/metronome-engraver.cc:87: text_->get_property_data
("break-align-symbols"))
get_property ()

http://codereview.appspot.com/1579041/diff/19001/20003#newcode96
lily/metronome-engraver.cc:96: grob_name_scm (Grob *g)
ly_symbol2scm (g->name ().c_str ());

though I'd prefer more lisp-like syntax for this using
camel_case_to_lisp_identifier ()

http://codereview.appspot.com/1579041/diff/19001/20003#newcode109
lily/metronome-engraver.cc:109: text_->get_property_data
("non-break-align-symbols"))
get_property ()

http://codereview.appspot.com/1579041/diff/19001/20006
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/1579041/diff/19001/20006#newcode610
scm/define-grob-properties.scm:610: (non-break-align-symbols ,list? "A
list of symbols that determine
needs adding to an interface

http://codereview.appspot.com/1579041/diff/19001/20007
File scm/define-grobs.scm (right):

http://codereview.appspot.com/1579041/diff/19001/20007#newcode418
scm/define-grobs.scm:418: metronome-mark
Is this necessary?

IIUC, only break-aligned grobs will be acknowledged by the
Break_align_engraver, so a MetronomeMark will never appear in the list
of elements for ordering.

http://codereview.appspot.com/1579041/diff/19001/20007#newcode1161
scm/define-grobs.scm:1161: break-alignable-interface
+ self-alignment-interface

otherwise regtests spit out loads of warnings for missing interface
(from self-alignment-X setting)

http://codereview.appspot.com/1579041/show