Re: dist failure for gub

[Jan Nieuwenhuizen]

Op maandag 05-07-2010 om 03:51 uur [tijdzone +0200], schreef Reinhold
Kainhofer:

> > Apparently the newly added lilypond-book directory does something
> > stupid, builds without using a target or something.
> 
> Not that I can see.

Stupid is not the right word, silly is probably better :-)

Turns out that lilypond-book-vars.make had

 LILYBOOK_TEXI_FILES = $(call src-wildcard *.texi)
 EXTRA_DIST_FILES += .. $(LILYBOOK_TEXI_FILES)

and texinfo-vars.make has

 TEXI_FILES = $(call src-wildcard *.texi)
 ALL_SOURCES += $(TEXI_FILES)

which makes that texi files were duplicated in the dist_files
list.  Now that I write this, I realise how fragile this is
and wonder why we, instead of

  $(LN) $(DIST_FILES:%=$(src-dir)/%) $(distdir)/$(localdir)

have something like

  UNIQUE_DIST_FILES = $(sort $(DIST_FILES)
  $(LN) $(UNIQUE_DIST_FILES:%=$(src-dir)/%) $(distdir)/$(localdir)

to allow duplicates in DIST_FILES.  Oh well...

Jan.

-- 
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyOfSource.com | Avatar®  http://AvatarAcademy.nl