|
From: | n . puttock |
Subject: | Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041) |
Date: | Sun, 01 Aug 2010 14:27:05 +0000 |
http://codereview.appspot.com/1908041/diff/10002/18002 File python/convertrules.py (right): http://codereview.appspot.com/1908041/diff/10002/18002#newcode3014 python/convertrules.py:3014: 'accDot': 'dot', indent http://codereview.appspot.com/1908041/diff/10002/18002#newcode3018 python/convertrules.py:3018: 'accOldEE': 'oldEE'} missing 'accDiscant' http://codereview.appspot.com/1908041/diff/10002/18002#newcode3019 python/convertrules.py:3019: return '"\1%s"' % d[m.group (2)] This doesn't work for the `accordion.' part: it returns the matched object rather than the string. It seems you need to expand the backreference and add an extra backslash: return m.expand ('"\\1%s"' % d[m.group (2)]) http://codereview.appspot.com/1908041/show
[Prev in Thread] | Current Thread | [Next in Thread] |