Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

[n . puttock]

On 2010/08/01 20:09:40, dak wrote:

> "make test" did not turn up problems with unpatched docs (the docs are
> really just few lines in one file: there is no serious doc to speak
of).
> But I don't really understand why.

\musicglyph doesn't warn for invalid strings, so they slip through
silently.

> I can make the doc change a separate commit or not, whatever people
> prefer.  Given its minimal size (and the disturbing detail that it
does
> not change the version number of the snippet, anyway), I'd think that
a
> single commit may be appropriate.

LSR snippets get stamped with the last convert rule's version whenever a
full update's done, so the accordion snippet's version was already at
2.13.29 from the autobeaming changes.

I think a single commit's fine.

Cheers,
Neil

http://www.codereview.appspot.com/1908041/show