Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

[pnorcks]

On 2010/07/29 19:24:46, Neil Puttock wrote:

> + = scm_list_3 (ly_symbol2scm ("module-use!"), mod, used);

> This effectively exports all bindings, so all local defines are now
exported.

> In the case of `profile-property-access.ly', the format call ends up
using
> `ergonomic-simple-format' from lily.scm.

Thanks for this observation, Neil.

The reason why I suggested this change is to prevent a compile failure
with Guile 1.9.  The backtrace is below.  Perhaps there is a bug in the
`module-public-interface' procedure?  Not really sure how to test if
this is the case though...


Processing
`/home/pnorcks/git/lilypond/ly/generate-documentation.ly'/home/pnorcks/git/lilypond/out/share/lilypond/current/scm/lily.scmBacktrace:
In ice-9/boot-9.scm:
 170: 14 [catch #t #<catch-closure 22a71e0> ...]
In unknown file:
   ?: 13 [catch-closure]
In /home/pnorcks/git/lilypond/scm/lily.scm:
 752: 12 [lilypond-main #<variable 294e830 value: #>]
 776: 11 [lilypond-all
("/home/pnorcks/git/lilypond/ly/generate-documentation")]
In unknown file:
   ?: 10 [for-each #<procedure 2bc2080 at
/home/pnorcks/git/lilypond/scm/lily.scm:776:5 (x)> ...]
In /home/pnorcks/git/lilypond/scm/lily.scm:
 789: 9 [#<procedure 2bc2080 at
/home/pnorcks/git/lilypond/scm/lily.scm:776:5 (x)>
"/home/pnorcks/git/lilypond/ly/generate-documentation"]
In ice-9/boot-9.scm:
 170: 8 [catch ly-file-failed ...]
In unknown file:
   ?: 7 [ly:parse-file
"/home/pnorcks/git/lilypond/ly/generate-documentation"]
In ice-9/boot-9.scm:
1949: 6 [module-use! #<module (#{\ g446}#) 2deac60> #<interface (lily)
22b6ea0>]
In unknown file:
   ?: 5 [filter #<procedure 2a330e0 at ice-9/boot-9.scm:1948:42 (m)>
({#f})]
In ice-9/boot-9.scm:
1951: 4 [#<procedure 2a330e0 at ice-9/boot-9.scm:1948:42 (m)> {#f}]
2158: 3 [#<procedure 214c980 at ice-9/boot-9.scm:2156:4 (mod)> {#f}]
 759: 2 [#<procedure 20f1930 at ice-9/boot-9.scm:757:4 (obj)> {#f}]
 115: 1 [#<procedure 22508c0 at ice-9/boot-9.scm:109:6 (thrown-k .
args)> wrong-type-arg ...]
In unknown file:
   ?: 0 [catch-closure wrong-type-arg "struct_vtable" ...]

ERROR: In procedure struct_vtable:
ERROR: Wrong type argument in position 1 (expecting struct): #f


http://www.codereview.appspot.com/1160044/show