Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

[n . puttock]

On 2010/08/01 00:11:44, Ian Hulin wrote:

> How did you guys track it down to this module?

Since Patrick had already reported the failure, I cheated by applying
the patch and compiling profile-property-access.ly. :)

> I only get from the
> regression test is this message (this is the tail of the log file).
> <snip>

You should find the failed file further up the log.  Here's what I get:

Processing ./snippet-map--4234561403288800728
Failed files: (a1/lily-624a475e.ly)
logfile lilypond-multi-run-0.log (exit 1):
3/lily-9bd4398b
Processing da/lily-cddc2009
Processing 7b/lily-66b6addb
Processing f2/lily-115c7a97
Processing 1f/lily-aee531b8
Processing af/lily-14cabdbc
Processing 69/lily-663ee4f1
Processing 3c/lily-cf6046fa
Processing a3/lily-71898ac9
Processing 2d/lily-ca1387bf
Processing 26/lily-79010cda
Processing 76/lily-3893c7bc
Processing 09/lily-799c5df9
Processing 3f/lily-d9e46c0b
Processing bf/lily-d81dd530
Processing 6e/lily-5044bcc8
Processing f7/lily-936b0942
Processing 98/lily-6a58999c
Processing f2/lily-18f644bf
Processing 54/lily-7f91ee15
Processing b5/lily-7a515599
Processing 99/lily-fd2ab7dd
Processing aa/lily-35c4032b
Processing b0/lily-ef53b86d
Processing ba/lily-fb56b7d4
Processing c7/lily-eafa763e
Processing 6b/lily-7194d224
Processing e5/lily-06b49319
Processing ee/lily-cd629890
Processing 45/lily-8d2b9d96
Processing 61/lily-e50cd566
Processing aa/lily-c55a6eaf
Processing d4/lily-51c86602
Processing c4/lily-11400a53
Processing 65/lily-ab78a8a7
Processing a8/lily-f8232be1
Processing 52/lily-23a75a14
error: Children (2 0) exited with errors.

The log file for the failed snippet is here:

out/lybook-testdb/a1/lily-624a475e.log

> Unless I misunderstood Han-Wen,that's why we were jerking around with
> %module-public-interface in the first place.

Sure, but we only want the public interface from (lily), otherwise all
functions defined in .scm are accessible anywhere.

For example, `get-outfile-name' in lily-library.scm isn't public, yet I
can access it from a .ly file:

#(display (defined? 'get-current-filename))

-> #t

#(display get-current-filename)

-> #<procedure get-current-filename (parser)>

Cheers,
Neil

http://www.codereview.appspot.com/1160044/show