[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adds announce-end-grob to engraver-scheme.cc (issue1914043)
From: |
mtsolo |
Subject: |
Re: Adds announce-end-grob to engraver-scheme.cc (issue1914043) |
Date: |
Tue, 03 Aug 2010 08:36:36 +0000 |
http://codereview.appspot.com/1914043/diff/6001/7001
File lily/engraver-scheme.cc (right):
http://codereview.appspot.com/1914043/diff/6001/7001#newcode26
lily/engraver-scheme.cc:26: " with give @code{grob_name}, a symbol.
@code{cause}"
On 2010/08/02 22:56:25, Neil Puttock wrote:
with given @code{grob-name},
Done.
http://codereview.appspot.com/1914043/diff/6001/7001#newcode42
lily/engraver-scheme.cc:42: " Announces an end grob originating from
given engraver instance,"
On 2010/08/02 22:56:25, Neil Puttock wrote:
This could be a bit clearer (an `end grob' doesn't make much sense)
Done.
http://codereview.appspot.com/1914043/diff/6001/7001#newcode44
lily/engraver-scheme.cc:44: " be another grob or a music event.")
On 2010/08/02 22:56:25, Neil Puttock wrote:
indent
Done.
http://codereview.appspot.com/1914043/diff/6001/7001#newcode47
lily/engraver-scheme.cc:47: LY_ASSERT_TYPE (unsmob_grob, grob, 2);
On 2010/08/02 22:56:25, Neil Puttock wrote:
LY_ASSERT_SMOB (Grob, grob, 2);
Done.
http://codereview.appspot.com/1914043/show
- Re: Adds announce-end-grob to engraver-scheme.cc (issue1914043),
mtsolo <=