Re: Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) (issue1986042)

[n . puttock]

Hi Carl,

LGTM.

Cheers,
Neil


http://codereview.appspot.com/1986042/diff/1/2
File scm/define-music-display-methods.scm (right):

http://codereview.appspot.com/1986042/diff/1/2#newcode887
scm/define-music-display-methods.scm:887: (let* ((arguments
(ly:music-property expr 'time-signature-arguments))
I'd prefer separate properties since it would make the output of
\displayMusic less cryptic.

There's already 'numerator and 'denominator (which are currently used
for \times, even though their docstrings mention \time).

http://codereview.appspot.com/1986042/diff/1/2#newcode897
scm/define-music-display-methods.scm:897: "#(set-time-signature ~a ~a
~a)~a"
"#(set-time-signature ~a ~a '~a)~a"

http://codereview.appspot.com/1986042/diff/1/4
File scm/define-music-types.scm (right):

http://codereview.appspot.com/1986042/diff/1/4#newcode53
scm/define-music-types.scm:53: (define (make-time-signature-set music)
We should probably think about moving these to a separate file now
there's more than one callback.

(naturally this can wait for another patch)

http://codereview.appspot.com/1986042/diff/1/5
File scm/music-functions.scm (left):

http://codereview.appspot.com/1986042/diff/1/5#oldcode507
scm/music-functions.scm:507: (define-public
(make-beam-rule-time-signature-set num den rest)
Do you want to keep this?

http://codereview.appspot.com/1986042/show