Re: Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) (issue1986042)

[Carl . D . Sorensen]

Let me know about the filename for the new callbacks, and I'll add that
to this patch and push it.

THanks,

Carl


http://codereview.appspot.com/1986042/diff/1/2
File scm/define-music-display-methods.scm (right):

http://codereview.appspot.com/1986042/diff/1/2#newcode887
scm/define-music-display-methods.scm:887: (let* ((arguments
(ly:music-property expr 'time-signature-arguments))
On 2010/08/13 21:25:13, Neil Puttock wrote:
> I'd prefer separate properties since it would make the output of
\displayMusic
> less cryptic.

> There's already 'numerator and 'denominator (which are currently used
for
> \times, even though their docstrings mention \time).

Ah, got it.  I hadn't thought of displayMusic.  Done.

http://codereview.appspot.com/1986042/diff/1/2#newcode897
scm/define-music-display-methods.scm:897: "#(set-time-signature ~a ~a
~a)~a"
On 2010/08/13 21:25:13, Neil Puttock wrote:
> "#(set-time-signature ~a ~a '~a)~a"

Of course!  Thanks, Done.

http://codereview.appspot.com/1986042/diff/1/4
File scm/define-music-types.scm (right):

http://codereview.appspot.com/1986042/diff/1/4#newcode53
scm/define-music-types.scm:53: (define (make-time-signature-set music)
On 2010/08/13 21:25:13, Neil Puttock wrote:
> We should probably think about moving these to a separate file now
there's more
> than one callback.


maybe something like scm/define-music-callbacks.scm ?

> (naturally this can wait for another patch)

http://codereview.appspot.com/1986042/diff/1/5
File scm/music-functions.scm (left):

http://codereview.appspot.com/1986042/diff/1/5#oldcode507
scm/music-functions.scm:507: (define-public
(make-beam-rule-time-signature-set num den rest)
On 2010/08/13 21:25:13, Neil Puttock wrote:
> Do you want to keep this?

Of course not.  Thanks for the catch.

Done

http://codereview.appspot.com/1986042/show