lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add tab-tie-follow-engraver (issue2723043)


From: Carl . D . Sorensen
Subject: Re: Add tab-tie-follow-engraver (issue2723043)
Date: Fri, 12 Nov 2010 04:08:37 +0000

On 2010/11/07 09:24:31, marc wrote:
Am 07.11.2010 08:47, schrieb address@hidden:
> In this patch, the glissando, slur, tie, and repeat-tie callbacks
have
> been modified.  The slur callback doesn't even check for the tie
status,
> since there's no change.
But it has to take the value of 'display-cautionary into account,
isn't it?

As far as I could see from the existing code, there was no difference
for the slur based on the style of the note.  The slur goes from the top
center of the note, which is the same in both cases, I think.

> I think that this is the right logic.  Because the tie can be split,
the
> tie (and repeat-tie) callbacks need to decide on the note head
display.
> The slur and glissando callbacks don't need to set the display, they
> just respond to it if need be.
+1

Thanks for the confirmation.

Carl


http://codereview.appspot.com/2723043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]