Re: Add tab-tie-follow-engraver (issue2723043)

[n . puttock]

Hi Carl,

What do you think about folding this code into the
Tab_note_heads_engraver?  We could store the created TabNoteHead grobs
and add an acknowledger for Tie, then set 'tie-follow in
stop_translation_timestep ().

Cheers,
Neil


http://codereview.appspot.com/2723043/diff/31001/lily/tab-tie-follow-engraver.cc
File lily/tab-tie-follow-engraver.cc (right):

http://codereview.appspot.com/2723043/diff/31001/lily/tab-tie-follow-engraver.cc#newcode72
lily/tab-tie-follow-engraver.cc:72: SCM proc = ly_lily_module_constant
("ly:spanner-bound");
remove

http://codereview.appspot.com/2723043/diff/31001/lily/tab-tie-follow-engraver.cc#newcode75
lily/tab-tie-follow-engraver.cc:75: SCM right_bound =
ties_[1]->get_bound (LEFT);
Item *right_bound = ties_[i]->get_bound (RIGHT);

(will require casting or declaring ties_ as vector<Spanner *>)

http://codereview.appspot.com/2723043/diff/31001/lily/tab-tie-follow-engraver.cc#newcode78
lily/tab-tie-follow-engraver.cc:78: if (right_bound ==
note_heads_[k]->self_scm ())
if (right_bound = note_heads_[k])

(again, casting required, or declare note_heads_ as vector<Item *>)

http://codereview.appspot.com/2723043/diff/31001/scm/tablature.scm
File scm/tablature.scm (right):

http://codereview.appspot.com/2723043/diff/31001/scm/tablature.scm#newcode187
scm/tablature.scm:187: (if tie-follow
the tie callback shouldn't care about 'tie-follow, so this extra code
should be removed

http://codereview.appspot.com/2723043/diff/31001/scm/tablature.scm#newcode223
scm/tablature.scm:223: (if tie-follow
see comment for tie::handle-tab-note-head

http://codereview.appspot.com/2723043/diff/31001/scm/tablature.scm#newcode266
scm/tablature.scm:266: (ly:grob-set-property! left-tab-note-head
'stencil
add

(set! (ly:grob-property tied-tab-note-head 'transparent) #t)

http://codereview.appspot.com/2723043/diff/31001/scm/tablature.scm#newcode279
scm/tablature.scm:279: (ly:grob-set-property! left-tab-note-head
'stencil
add

(set! (ly:grob-property tied-tab-note-head 'transparent) #t)

http://codereview.appspot.com/2723043/