Re: PartCombine: Implement part-combine texts on the first real note (issue3285042)

[n . puttock]

http://codereview.appspot.com/3285042/diff/1/input/regression/part-combine-text-wait.ly
File input/regression/part-combine-text-wait.ly (right):

http://codereview.appspot.com/3285042/diff/1/input/regression/part-combine-text-wait.ly#newcode10
input/regression/part-combine-text-wait.ly:10: \version "2.13.41"
move to top

http://codereview.appspot.com/3285042/diff/1/input/regression/part-combine-text-wait.ly#newcode13
input/regression/part-combine-text-wait.ly:13: \set
Score.partCombineTextsOnNote = ##t
indent

http://codereview.appspot.com/3285042/diff/1/input/regression/part-combine-text-wait.ly#newcode18
input/regression/part-combine-text-wait.ly:18: c4 r2. |
indent

http://codereview.appspot.com/3285042/diff/1/input/regression/part-combine-text-wait.ly#newcode24
input/regression/part-combine-text-wait.ly:24: \new Staff \partcombine
\mI \mII
indent

http://codereview.appspot.com/3285042/diff/1/lily/part-combine-engraver.cc
File lily/part-combine-engraver.cc (right):

http://codereview.appspot.com/3285042/diff/1/lily/part-combine-engraver.cc#newcode91
lily/part-combine-engraver.cc:91: text_ = make_item
("CombineTextScript", /*ev?(ev->self_scm ()):*/SCM_EOL);
What's up with the event-cause setting?

http://codereview.appspot.com/3285042/diff/1/lily/part-combine-engraver.cc#newcode102
lily/part-combine-engraver.cc:102: if (have_note || !to_boolean
(get_property ("partCombineTextsOnNote")))
On 2010/11/25 11:21:58, Valentin Villenave wrote:
> Are you sure you want to use a plural in the property name? I'm not
sure that's
> what we do usually (other than "fretboards" etc.): see e.g.
tieWaitForNote, all
> singular.

I don't mind either way, but the plural's in keeping with
printPartCombineTexts.

http://codereview.appspot.com/3285042/diff/1/scm/define-context-properties.scm
File scm/define-context-properties.scm (right):

http://codereview.appspot.com/3285042/diff/1/scm/define-context-properties.scm#newcode365
scm/define-context-properties.scm:365: note rather than immediately")
could be more specific (if, as I understand it, `immediately' only
applies to rests).

http://codereview.appspot.com/3285042/