lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix 1456 (issue3693042)


From: pkx166h
Subject: Re: Fix 1456 (issue3693042)
Date: Mon, 20 Dec 2010 01:20:30 +0000

Just some Nitpicks


http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode1111
Documentation/notation/rhythms.itely:1111: c8^\markup "Beamed (2 2)"
\repeat unfold 7 { c8 } |
c8^ \markup { "Beamed (2 2)" } as per CG also I'd personally put the
\repeat on a new line.

http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode1119
Documentation/notation/rhythms.itely:1119: c8^\markup "Beamed (3 1)"
\repeat unfold 7 { c8 } |
Same as above.

http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode1172
Documentation/notation/rhythms.itely:1172: #'()
  % beamExceptions
The spacing here with the comments after each #'() construct is
inconsistent with the example above.

http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode1175
Documentation/notation/rhythms.itely:1175: }
This brace needs one more space by the looks of it

http://codereview.appspot.com/3693042/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]