lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixes accidental suggestions in the beam collision engraver (issue42


From: Han-Wen Nienhuys
Subject: Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)
Date: Sun, 20 Mar 2011 22:59:20 -0300

On Sun, Mar 20, 2011 at 8:41 AM,  <address@hidden> wrote:
> Reviewers: ,
>
> Message:
> Hey all,
>
> A bug just hit the French list.  It seems like a critical regression.
>

Hi,

There is not much else we can do: the suggestion accidental uses the
stem extent to determine Y positions, but that requires formatting the
beam, which looks at the Y position of the accidental again.

The intention of the fix is incorrect, but can you make the logic
explicit? That is, add an interface symbol for "normal" accidentals
(normal-accidental-interface, inline-accidental-interface, ... ?) and
acknowledge that explicitly?  If not, we will screw in the same way
for any other accidental-like grob, eg. TrillPitchAccidental).

Also, add this snippet to the regtest:

{
  \set suggestAccidentals = ##t
   a'8[ fis'16 g'16]
}

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]