Re: Fixes issue 1628. (issue 4876051)

[Han-Wen Nienhuys]

Your patch is doing much more than address issue 1628.  Can you do
just the change to the engraver to close issue 1628?   Any ensuing
collisions should be made into a new issue.

Are you sure exclude_extra_objects_outside_x_range() is really needed?
We already have

          Real x = info.extents_[X_AXIS].linear_combination (info.idx_);

          if (!slur_wid.contains (x))
            continue;

I don't think we can realistically mess with the offsets of
extra-encompass objects in the slur scoring (or, in general: change
dependency order during formatting): other objects may already have
used the object's position (which you are trying to invalidate) to
make other decisions.  Eg. what if a skyline algorithm has already
read the position of the grob?

If you want to have more adaptive behavior, you need to have a
super-grob which coordinates between slur and encompass objects, like
we have for note and rest-collisions.

On Mon, Aug 15, 2011 at 6:17 PM,  <address@hidden> wrote:
> Reviewers: ,
>
> Message:
> Cheers,
> MS
>
> Description:
> Fixes issue 1628.
>
> Please review this at http://codereview.appspot.com/4876051/
>
> Affected files:
>  M lily/include/slur-scoring.hh
>  M lily/include/slur.hh
>  M lily/new-fingering-engraver.cc
>  M lily/slur-configuration.cc
>  M lily/slur-engraver.cc
>  M lily/slur-scoring.cc
>  M lily/slur.cc
>  M scm/define-grob-properties.scm
>  M scm/define-grobs.scm
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/lilypond-devel
>



-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen