[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixes issue 1628. (issue 4876051)
From: |
k-ohara5a5a |
Subject: |
Re: Fixes issue 1628. (issue 4876051) |
Date: |
Wed, 17 Aug 2011 20:42:37 +0000 |
LGTM
Now string numbers move around slurs as well.
That didn't work in the old patch, nor in 2.14.
The old regtest string-number-around-slur.ly avoided collisions only by
accident. Different pitches would cause collisions with the string
numbers, but after this patch they really move #'around the slur.
http://codereview.appspot.com/4876051/diff/8001/input/regression/string-number-around-slur.ly
File input/regression/string-number-around-slur.ly (right):
http://codereview.appspot.com/4876051/diff/8001/input/regression/string-number-around-slur.ly#newcode9
input/regression/string-number-around-slur.ly:9: \textLengthOn
Alternatively, if you remove \textLengthOn, the numbers go to their
original in-in-out positions, and the natural spacing gives a more
realistic test.
http://codereview.appspot.com/4876051/