|
| From: | ianhulin44 |
| Subject: | Re: Fix uninitialized variables when Source_file::get_counts returns early due to !contains (pos_str0) (issue 4940047) |
| Date: | Tue, 23 Aug 2011 18:21:00 +0000 |
LGTM Maybe we should have some GOP rules for C++ about this? "Only have multiple exit points from routines if you absolutely have to. Make sure any output parameters are declared and initialized at the top of a routine so that however a routine exits, they are left in a defined state" Ian http://codereview.appspot.com/4940047/
| [Prev in Thread] | Current Thread | [Next in Thread] |