lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Sketch for broken beams with consistent slopes (issue 4961041)


From: Mike Solomon
Subject: Re: Sketch for broken beams with consistent slopes (issue 4961041)
Date: Mon, 3 Oct 2011 20:50:55 +0200

On Oct 3, 2011, at 6:53 AM, address@hidden wrote:

> i know it's annoying, but could you separate out the cosmetics (adding _
> ) to members from the rest of this change?  The cosmetic changes make it
> difficult to see the essence of what you are trying to do.
> 
> 
> http://codereview.appspot.com/4961041/diff/39001/lily/include/beam-scoring-problem.hh
> File lily/include/beam-scoring-problem.hh (right):
> 
> http://codereview.appspot.com/4961041/diff/39001/lily/include/beam-scoring-problem.hh#newcode151
> lily/include/beam-scoring-problem.hh:151: vector<Real> stem_ypositions_;
> organize so it's clear to what members the comment pertains.
> 
> http://codereview.appspot.com/4961041/

Doable.
I'll push the cosmetic to master after running regtests on it and then try to 
sort out the patch either tonight or tomorrow morning.

Cheers,
MS


reply via email to

[Prev in Thread] Current Thread [Next in Thread]