Re: Glyphs for Kievan Notation (issue 4951062)

[bordage . bertrand]

Here's the second part of my review.  I saw that kievan notation has
beams, contrary to what I thought.  If you're intrepid, you can also try
to implement the kievan beaming parameters in you KievanVoice.

Hold on, it's the end!
Bertrand


http://codereview.appspot.com/4951062/diff/64002/mf/parmesan-clefs.mf
File mf/parmesan-clefs.mf (right):

http://codereview.appspot.com/4951062/diff/64002/mf/parmesan-clefs.mf#newcode1738
mf/parmesan-clefs.mf:1738: % TODO: merge this code with the above
Obviously, this must be done.  This is easy, you just have to define the
glyph and create two characters with it:


def draw_kievan_do_clef =
    z1 = [...]
[...]
enddef;

fet_beginchar ([...]);
    draw_kievan_do_clef;
fet_endchar;

fet beginchar ([...]_change");
    % TODO: make a different glyph for changes, but
    % dunno what a kievan clef looks like in changes...
    draw[...];
endchar;

http://codereview.appspot.com/4951062/diff/64002/mf/parmesan-noteheads.mf
File mf/parmesan-noteheads.mf (right):

http://codereview.appspot.com/4951062/diff/64002/mf/parmesan-noteheads.mf#newcode1861
mf/parmesan-noteheads.mf:1861: fet_beginchar ("kievan half note (space
position)", "s1rkievan");
Still "sr1kievan".

http://codereview.appspot.com/4951062/diff/64002/scm/output-lib.scm
File scm/output-lib.scm (right):

http://codereview.appspot.com/4951062/diff/64002/scm/output-lib.scm#newcode101
scm/output-lib.scm:101: (min 2
Maybe you could try to change "min 2" for "min 3" and remove what you
added before.  I'm totally unsure of that, we must check what's going on
downstream to be sure.

http://codereview.appspot.com/4951062/diff/64002/scm/output-lib.scm#newcode595
scm/output-lib.scm:595: (0 . "accidentals.vaticana0")
I guess there's no natural glyph in kievan notation since there is no
time signature and no accidental 'remembering'.  Can you confirm this?
Maybe we need to remove this line, then.  This will produce a warning
(but no crash) if one tries to use a natural in kievan style.

http://codereview.appspot.com/4951062/