Re: changes in chord names formatting (1503, 1572) (issue 4981052)

[Peekay Ex]

Adam,

On Wed, Nov 2, 2011 at 5:58 PM,  <address@hidden> wrote:
> I think I am now finished.  The new patch series is available at
>
>    https://github.com/aspiers/lilypond/commits/jazz
>
> IMHO there are now too many patches in the series to combine into a
> single commit for review.  To do so would lose a lot of clarity in the
> git history.  So I am not sure how this review process should proceed.

One patch per tracker item?

>
> Anyhow, you can fetch the patches via:
>
>    git remote add aspiers git://github.com/aspiers/lilypond.git
>    git fetch aspiers jazz

Sorry to belabor the point, but it is unlikely you are going to get
much review if those that understand this stuff (I don't, I just push
and pull and test formatted patches) have to get patches from a third
place.

Even if it is just a Rietveld Issue then that is better than having to
git fetch from another repo, we in the Bug Squad can create the
trackers for you.

>
> The patches also adjust the regression tests and English documentation
> to be consistent with changes to the code.  Translation work is required
> for other languages.
>
> http://codereview.appspot.com/4981052/

So should we now be ignoring the stuff in this Rietveld issue?

regards

-- 
--
James