lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixes to jazz chord displays (issue 5320074)


From: Carl . D . Sorensen
Subject: Re: Fixes to jazz chord displays (issue 5320074)
Date: Sat, 05 Nov 2011 14:33:32 +0000

Looks very good to me; a couple of minor changes suggested.



http://codereview.appspot.com/5320074/diff/14001/input/regression/chord-additional-pitch-prefix.ly
File input/regression/chord-additional-pitch-prefix.ly (right):

http://codereview.appspot.com/5320074/diff/14001/input/regression/chord-additional-pitch-prefix.ly#newcode1
input/regression/chord-additional-pitch-prefix.ly:1: \version "2.15.16"
Will need to be adjusted when it's ready to commit.  Right now, it
should be 2.15.17.

Version of new snippets is always one greater than the current release
version.

http://codereview.appspot.com/5320074/diff/14001/scm/define-context-properties.scm
File scm/define-context-properties.scm (right):

http://codereview.appspot.com/5320074/diff/14001/scm/define-context-properties.scm#newcode380
scm/define-context-properties.scm:380: (minorChordModifier ,markup? "How
should minor chords be formatted
I'd prefer "Markup displayed following the root for a minor chord."

http://codereview.appspot.com/5320074/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]