[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Gets rid of PostScript inbar-chords-notation-for-guitar--with-text-s
From: |
Phil Holmes |
Subject: |
Re: Gets rid of PostScript inbar-chords-notation-for-guitar--with-text-spanner.ly (issue 5529048) |
Date: |
Mon, 9 Jan 2012 14:24:45 -0000 |
----- Original Message -----
From: <address@hidden>
To: <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Monday, January 09, 2012 5:14 AM
Subject: Re: Gets rid of PostScript
inbar-chords-notation-for-guitar--with-text-spanner.ly (issue 5529048)
LGTM
I'm vaguely curious as to what's the difference between this postscript
and the regtest for postscript, but that's no reason to hold up
development. Besides, the lilypond markup is easier to understand than
the postscript, so this is a good change to make even if it wasn't a
build problem.
http://codereview.appspot.com/5529048/
_______________________________________________
lilypond-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Whoah. This is changes to snippets in the snippet directory. It actually
looks like the only substantive change if with the
Documentation/snippets/bar-chords-notation-for-guitar--with-text-spanner.ly
which is duplicated in snippets/new. Mike - you only need to edit the one
in snippets/new - the other should be updated in the LSR, and it will appear
in snippets/ when an LSR import is run. However, the snippets/new one takes
priority so it shouldn't make ant difference when this is done.
If this sounds right - I can do the edit and will do the import at some
time. There's also 3 other files with essentially null changes to them -
might be a cleaner patch if you get rid of these.
I think only Graham can comment on this - could you confirm, please, GP?
--
Phil Holmes