[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Gets rid of PostScript inbar-chords-notation-for-guitar--with-text-s
From: |
Graham Percival |
Subject: |
Re: Gets rid of PostScript inbar-chords-notation-for-guitar--with-text-spanner.ly (issue 5529048) |
Date: |
Tue, 10 Jan 2012 03:05:32 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 09, 2012 at 02:24:45PM -0000, Phil Holmes wrote:
> It
> actually looks like the only substantive change if with the
> Documentation/snippets/bar-chords-notation-for-guitar--with-text-spanner.ly
> which is duplicated in snippets/new. Mike - you only need to edit
> the one in snippets/new - the other should be updated in the LSR,
> and it will appear in snippets/ when an LSR import is run.
Correct in general, but the overall goal is to let Mike build the
docs again. As such, I think it's appropriate to dump the change
in snippets/new/ and run makelsr himself. If this was just a doc
clarification, then I'd suggest it be done the other way.
> If this sounds right - I can do the edit and will do the import at
> some time. There's also 3 other files with essentially null changes
> to them - might be a cleaner patch if you get rid of these.
Yes... the git history would be slightly more clear if he did a
local makelsr, then changed the one file in snippets/new/, then
did another local makelsr. But in this case I didn't think it was
worth asking for that level of bureaucracy.
- Graham