lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Don't wrap EventChord around rhythmic events by default. (issue 5440


From: dak
Subject: Re: Don't wrap EventChord around rhythmic events by default. (issue 5440084)
Date: Fri, 20 Jan 2012 14:55:39 +0000

On 2012/01/20 14:08:18, MikeSol wrote:

http://codereview.appspot.com/5440084/diff/11001/lily/rhythmic-music-iterator.cc
File lily/rhythmic-music-iterator.cc (right):


http://codereview.appspot.com/5440084/diff/11001/lily/rhythmic-music-iterator.cc#newcode62
lily/rhythmic-music-iterator.cc:62: if (scm_is_true
ly_lily_module_constant should only be called for things that don't
exist in
C++.

I've seen that elsewhere.  Maybe to support redefining the function
before it is first memoized.

Otherwise, it's better to use the C++ function.  In this case:
ly_is_listened_event_class
(in translator.cc)

Will do.

http://codereview.appspot.com/5440084/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]