lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Change all occurences of "echo -n" to "printf" for portability (issu


From: dak
Subject: Re: Change all occurences of "echo -n" to "printf" for portability (issue 5903046)
Date: Sat, 24 Mar 2012 06:34:45 +0000


http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh
File smart-autogen.sh (right):

http://codereview.appspot.com/5903046/diff/1/smart-autogen.sh#newcode16
smart-autogen.sh:16: printf $AUTOGEN_INPUT_CHECKSUM > $CHECKSUM_FILE
On 2012/03/24 06:00:52, dak wrote:
I'd prefer "%s" "$AUTOGEN_INPUT_CHECKSUM" here too in order to avoid
teaching
sloppy use of printf, but it can't actually do harm here since md5sum
does not
produce backslashes or percent characters.

And while we are at it: the trailing whitespace could be removed as
well.

http://codereview.appspot.com/5903046/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]