Re: Set indent based on instrument name (issue 6457049)

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: <address@hidden>; <address@hidden>; 
<address@hidden>; <address@hidden>; <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Tuesday, July 31, 2012 2:36 PM
Subject: Re: Set indent based on instrument name (issue 6457049)


> http://codereview.appspot.com/6457049/diff/4001/lily/output-def.cc
> File lily/output-def.cc (right):
>
> http://codereview.appspot.com/6457049/diff/4001/lily/output-def.cc#newcode275
> lily/output-def.cc:275: set_inst_name_len (Real long_inst_name_len, Real
> short_inst_name_len)
> Correct me if I am wrong, but it does not seem like you initialize
> long_name_len/short_name_len other than globally.  Meaning that the
> instrument names of the whole LilyPond run (possibly over thousands of
> documentation snippets) are relevant for the results at the end.
>
> http://codereview.appspot.com/6457049/

Correct.  I realised that last night, and this is why make test fails.  I 
sent an email identifying this as a problem, although I realise you can't 
possibly read every email.  The lengths need to be reset whenever there is a 
new score block.

--
Phil Holmes