Re: Regtest changes phase 1 (issue 6454121)

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: <address@hidden>; <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Wednesday, August 08, 2012 7:15 PM
Subject: Re: Regtest changes phase 1 (issue 6454121)


> Sorry Phil, but I don't think this is an improvement.
>
> a) The original code comments explain much more clearly
> what is being tested than do your new marks.
>
> b) Although the marks don't affect the test they do
> tend to mask the real tests and make it harder to see
> what is really being tested.
>
> I'd leave the code alone and expand the description if
> further clarity is needed.
>
> Trevor


Absolutely appreciate this comment.  However, the theory of the regtests is 
that by looking at the description and the image, you can tell whether the 
regtest has been passed.  No-one who looked at this regtest could do that. 
With the changes proposed, you can.   The question is - do you need to 
inspect the code, or the image and description, to tell whether the regtest 
has been passed?

--
Phil Holmes