Re: Removes popen3 deprecated warning (issue 6471043)

[Trevor Daniels]

Graham Percival wrote Saturday, August 18, 2012 7:34 PM


> On Sat, Aug 18, 2012 at 05:23:17PM +0100, Phil Holmes wrote:
>
>> Between 2.15.18 and 2.15.21
> 
> Given that 2.15.21 was released on 2011 Dec 6, why were we working
> on issue 1933 on 2012 Jan 12 ?  was it just a misunderstanding
> about which GUB versions had the problem?

Issue 1933 was originally reported just before 25 Sep 2011 as a bug 
in 2.15.12, although I believe it first appeared in 2.15.10, following a 
patch from Reinhold.

It lay dormant as a critical issue until 30 Dec 2011, when Carl began trying
to get GUB to work in order to investigate it.  That came to nothing.  

On 11 Jan 2012 Graham began building a series of special releases which I
tested in order to isolate the problems.  There were several, including the
msvcrt one, which were eventually all fixed in 
ab8dfc6e8f3de3cefc8fab09a4993acaec460720 committed on 12 Jan 2012.  

This fix first appeared in 2.15.25.  AFAIK it's been ok since then.  I've
used lilypond-book from several recent releases, including 2.15.95, under
Windows Vista without any problems, not even the one Phil is trying to
fix.

I don't know what Phil thinks was fixed between 2.15.18 and 2.15.21,
but I do suspect the symptoms of the problem or problems changed 
from release to release, and may even depend on the Windows setup.
 
> I have the same feeling as I do for the LILYPOND_RELOCATE_PREFIX.
> I'm not totally opposed to the patch going into master, but I
> would not be at all surprised if it broke something.  I'd feel a
> lot better if you made some binaries and got some user feedback
> from people using them on windows (ideally with at least 3
> different versions of windows).

Happy to test a binary Phil, if you can build one.

Trevor