Re: Check for Fontforge with enable-double (1637) (issue 6484062)

[dak]

On 2012/08/27 09:04:46, dak wrote:
> On 2012/08/26 22:56:44, John Mandereau wrote:
> > LGTM except one nitpick (see comment).
> >
> > http://codereview.appspot.com/6484062/diff/1/configure.in
> > File configure.in (right):
> >
> > http://codereview.appspot.com/6484062/diff/1/configure.in#newcode174
> > configure.in:174: if $FONTFORGE --version 2>&1|egrep -q -e
'-L?D\.?$'; then
> > It seems that egrep vs. grep and egrep/grep -e flag are redundant,
why not
> just
> > have "grep -q -e" instead?

> You are confusing grep -E with grep -e.  -e just says that the next
word is the
> regular expression to look for rather than an option, and it is
required since
> the regular expression starts with dash itself.

Actually, one should just use grep.  I just was not able to remember
whether plain grep needs ? or \? in its patterns and was too lazy to
look it up.

http://codereview.appspot.com/6484062/