lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bar-line interface part 2/2 (issue 6498052)


From: Marc Hohl
Subject: Re: bar-line interface part 2/2 (issue 6498052)
Date: Mon, 03 Sep 2012 17:31:34 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0

Am 02.09.2012 22:24, schrieb address@hidden:
More nit-picking:


http://codereview.appspot.com/6498052/diff/7003/python/convertrules.py
File python/convertrules.py (right):

http://codereview.appspot.com/6498052/diff/7003/python/convertrules.py#newcode3395
python/convertrules.py:3395: @rule ((2, 17, 2), r"New bar line
interface")

There's no converting rule for the old "|s"
(Note the small `s')

I'd suggest to do:
"|s" -> "|-s"
and to add
#(define-bar-line "|-s" "" "|" "|")
to /scm/bar-line.scm

http://codereview.appspot.com/6498052/

You are right. I'll include them in my next patch set,
probably after reworking the volta bracket stuff.

Thanks,

Marc



reply via email to

[Prev in Thread] Current Thread [Next in Thread]